Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_nodes: Add another dependency #1382

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

idk why this ever worked before. (this was not added with my latest tests but was there already before).

2024-11-22T11:04:00.2715563Z     from sensor_msgs.msg import JointState
2024-11-22T11:04:00.2716343Z ModuleNotFoundError: No module named 'sensor_msgs'

Closes #1375 (different error, but will fail tonight https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-source-build.yml)

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (1bd6870) to head (da97226).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
+ Coverage   83.57%   83.59%   +0.02%     
==========================================
  Files         122      122              
  Lines       10987    10983       -4     
  Branches      939      935       -4     
==========================================
- Hits         9182     9181       -1     
  Misses       1490     1490              
+ Partials      315      312       -3     
Flag Coverage Δ
unittests 83.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a random topology change, as the package doesn't have any ros2_controllers dependency, but some controllers do.

That should have shown in the buildfarm, though.

@christophfroehlich
Copy link
Contributor Author

Ah, this is python code which we haven't tested at all in the CI. This is why the build farm hasn't complained earlier?!

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Nov 22, 2024
@christophfroehlich christophfroehlich merged commit 9b344c7 into master Nov 22, 2024
19 of 20 checks passed
@christophfroehlich christophfroehlich deleted the fix/deps_again branch November 22, 2024 13:22
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
(cherry picked from commit 9b344c7)
christophfroehlich added a commit that referenced this pull request Nov 22, 2024
(cherry picked from commit 9b344c7)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build job jazzy/source failed!
2 participants