fix jerk limiter in diff_drive_controller #1390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be an error in the jerk limiter (speed_limiter.cpp#L117-L134) caused by the (as far as I can tell) incorrect factor 2 in the computation of the velocity limit resulting from jerk limits.
The consequence is an overshoot of the configured jerk limit.$J_{max} = 20 \text{ m.s}^{-3}$ such that
To illustrate the effect of this factor, let us set the linear jerk limit as
Before this PR, the jerk reaches$40 \text{ m.s}^{-3}$ :
After this PR: