Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit cast to period.count() (backport #1404) #1405

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 1, 2024

period.count() does not return an integer.
Fails with changes from ros-controls/control_toolbox#239 otherwise.


This is an automatic backport of pull request #1404 done by Mergify.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (b133273) to head (15359e0).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...gripper_controllers/hardware_interface_adapter.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1405      +/-   ##
==========================================
+ Coverage   66.27%   66.31%   +0.03%     
==========================================
  Files         110      110              
  Lines       12662    12662              
  Branches     7812     7815       +3     
==========================================
+ Hits         8392     8397       +5     
- Misses       1409     1415       +6     
+ Partials     2861     2850      -11     
Flag Coverage Δ
unittests 66.31% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gripper_controllers/hardware_interface_adapter.hpp 56.66% <0.00%> (ø)

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 0e28df8 into humble Dec 1, 2024
8 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1404 branch December 1, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant