Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call shutdown() after an exception (backport #1400) #1411

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2024

Closes #1383 acc. to the hint given by @firesurfer


This is an automatic backport of pull request #1400 done by Mergify.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.31%. Comparing base (7904d4b) to head (8d5f1e7).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1411      +/-   ##
==========================================
+ Coverage   66.27%   66.31%   +0.03%     
==========================================
  Files         110      110              
  Lines       12662    12656       -6     
  Branches     7813     7813              
==========================================
+ Hits         8392     8393       +1     
- Misses       1409     1411       +2     
+ Partials     2861     2852       -9     
Flag Coverage Δ
unittests 66.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...est_nodes/publisher_forward_position_controller.py 86.04% <100.00%> (+5.61%) ⬆️
...est_nodes/publisher_joint_trajectory_controller.py 55.37% <100.00%> (+1.33%) ⬆️

... and 3 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit ef8f100 into humble Dec 6, 2024
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1400 branch December 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant