Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error msg if empty message is received (backport #1424) #1428

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 17, 2024

There existed one branch where a goal is rejected but no error message is given.


This is an automatic backport of pull request #1424 done by Mergify.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.71%. Comparing base (7a2ad46) to head (29a41fa).
Report is 3 commits behind head on humble.

Files with missing lines Patch % Lines
...ory_controller/src/joint_trajectory_controller.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1428   +/-   ##
=======================================
  Coverage   66.70%   66.71%           
=======================================
  Files         113      113           
  Lines       13216    13219    +3     
  Branches     8152     8153    +1     
=======================================
+ Hits         8816     8819    +3     
  Misses       1442     1442           
  Partials     2958     2958           
Flag Coverage Δ
unittests 66.71% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 80.84% <83.33%> (+0.07%) ⬆️

@saikishor saikishor enabled auto-merge (squash) December 17, 2024 06:59
@saikishor saikishor disabled auto-merge December 17, 2024 06:59
@saikishor saikishor merged commit e6b00e1 into humble Dec 17, 2024
13 of 14 checks passed
@saikishor saikishor deleted the mergify/bp/humble/pr-1424 branch December 17, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants