Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump action-ros-ci to v0.2 #165

Closed

Conversation

matthew-reynolds
Copy link
Member

@matthew-reynolds matthew-reynolds commented Apr 5, 2021

Purpose

Bump ros-tooling/action-ros-ci to v0.2

Summary

Looks like the recent release of ros-tooling/setup-ros v0.1.3 pulled in a newer version of colcon-mixin, which elevated a warning to an error: ros-tooling/action-ros-ci#525 (comment)

This causes ros-tooling/action-ros-ci to fail out. The easiest approach is to just switch to the recently-released v0.2 and update our mixin rules according to ros-tooling/action-ros-ci#591

Testing To Do

  • CI passes
  • Code coverage still works

@matthew-reynolds
Copy link
Member Author

matthew-reynolds commented Apr 5, 2021

And of course, CI fails here without #164 due to flakey JTC tests 🤦‍♂️

We should be able to just rerun the CI on this PR to get it to pass though. I don't have permissions to rerun the job, can a maintainer rerun it?

@matthew-reynolds matthew-reynolds mentioned this pull request Apr 5, 2021
@bmagyar
Copy link
Member

bmagyar commented May 7, 2021

I'll close this for now, @matthew-reynolds feel free to reopen when a good reason to move presents itself.

@bmagyar bmagyar closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants