Minor cleanup & add TODOs for more #320
Conversation
github-actions
bot
requested review from
anfemosa,
arne48,
DasRoteSkelett,
destogl,
jaron-l and
kasiceo
|
How are TODOs used in this organization? Are they supposed to act as flags for minor things that anyone can pick up? I'm not sure how most people use them, but I've only used them as flags for work that needs to be done before the request is merged. |
destogl
removed request for
arne48,
DasRoteSkelett,
jaron-l,
anfemosa and
kasiceo
|
@jaron-l you are right, todos should be resolved before merge or is bigger changes are needed we should open an follow up issue describing it and referencing it in the code. Other than that, this PR should be 'draft' because we will open a lot of issues from the todos. (You can tackle some of them if you like) |
|
This pull request is in conflict. Could you fix it @bmagyar? |
3 similar comments
|
This pull request is in conflict. Could you fix it @bmagyar? |
|
This pull request is in conflict. Could you fix it @bmagyar? |
|
This pull request is in conflict. Could you fix it @bmagyar? |
|
I'll close this PR in favor of #944, let's discuss things there. |
No description provided.