Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Steering controllers lib] Improve docs #785

Merged

Conversation

christophfroehlich
Copy link
Contributor

Fixing some typos and adding additional context. However, open_loop mode seems to be broken see #784

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #785 (d883421) into master (f7c13ad) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   30.88%   30.88%           
=======================================
  Files           7        7           
  Lines         832      832           
  Branches      505      505           
=======================================
  Hits          257      257           
  Misses        133      133           
  Partials      442      442           
Flag Coverage Δ
unittests 30.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmagyar
Copy link
Member

bmagyar commented Sep 29, 2023

Thanks for flagging up the bug

@bmagyar bmagyar merged commit ca38c06 into ros-controls:master Sep 29, 2023
14 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 29, 2023
(cherry picked from commit ca38c06)
bmagyar pushed a commit that referenced this pull request Oct 5, 2023
@christophfroehlich christophfroehlich deleted the improve_steering_lib_docs branch November 15, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants