added documentation on common controller parameters #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
erickisos,
jaron-l,
malapatiravi and
sachinkum0009
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 47.22% 46.58% -0.64%
==========================================
Files 40 40
Lines 3636 3636
Branches 1716 1716
==========================================
- Hits 1717 1694 -23
- Misses 735 759 +24
+ Partials 1184 1183 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmagyar
approved these changes
Nov 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit 3555685)
bmagyar
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit 3555685) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've add some minor documentation update on the common controller parameters for every ROS2 Controller.
@christophfroehlich FYI