Increase test coverage (backport #856) #865
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
harderthan,
homalozoa,
mhubii and
progtologist
|
Needs #769 to build. |
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-856
branch
2 times, most recently
from
3230583 to
97110df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #865 +/- ##
==========================================
+ Coverage 45.27% 46.40% +1.13%
==========================================
Files 40 40
Lines 3722 3713 -9
Branches 1780 1769 -11
==========================================
+ Hits 1685 1723 +38
+ Misses 809 764 -45
+ Partials 1228 1226 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
| auto cmd_if_conf = range_broadcaster_->command_interface_configuration(); | ||
| ASSERT_THAT(cmd_if_conf.names, IsEmpty()); | ||
| auto state_if_conf = range_broadcaster_->state_interface_configuration(); | ||
| ASSERT_THAT(state_if_conf.names, SizeIs(1lu)); |
There was a problem hiding this comment.
Maybe in the future it also makes sense to check for the type to be NONE. What do you think @christophfroehlich ?
There was a problem hiding this comment.
I'm not sure about the implications, where this information is used etc. But yes, why not
There was a problem hiding this comment.
I think you can have type as ALL and not specify any names. So, the controller manager gets you access to all interfaces. That's the case for joint state broadcaster when no joints are specified I guess. Well this is for future, for now the PR looks good to me
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-856
branch
2 times, most recently
from
b4af5f5 to
97d874c
Compare
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-856
branch
2 times, most recently
from
c76aa40 to
bf17f24
Compare
(cherry picked from commit b6841ea)
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-856
branch
from
fc9f7a3 to
18761ad
Compare
This is an automatic backport of pull request #856 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com