Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Add console output for tolerance checks (backport #932) #938

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 21, 2023

This is an automatic backport of pull request #932 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (73961f2) 45.40% compared to head (2690e42) 45.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #938      +/-   ##
==========================================
+ Coverage   45.40%   45.75%   +0.35%     
==========================================
  Files          40       40              
  Lines        3713     3713              
  Branches     1769     1769              
==========================================
+ Hits         1686     1699      +13     
+ Misses        812      792      -20     
- Partials     1215     1222       +7     
Flag Coverage Δ
unittests 45.75% <14.28%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...include/joint_trajectory_controller/tolerances.hpp 55.00% <0.00%> (+10.00%) ⬆️
...ory_controller/src/joint_trajectory_controller.cpp 47.74% <16.66%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit 8fd5e83 into humble Jan 8, 2024
12 of 14 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-932 branch January 8, 2024 20:06
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
* use handles get_prefix_name() instead of wrong get_name()

* store state and command interfaces for transmissions

* test to check correct handle name

* format issues

* move accessor test to a new test file

* gtest is not needed

---------

Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Bence Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants