Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ament_cpplint job #972

Closed
wants to merge 1 commit into from
Closed

Fix ament_cpplint job #972

wants to merge 1 commit into from

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Jan 11, 2024

No description provided.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ament linter jobs are happy and I'm happy too.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feb3073) 45.48% compared to head (3373421) 45.48%.
Report is 2 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble     #972   +/-   ##
=======================================
  Coverage   45.48%   45.48%           
=======================================
  Files          40       40           
  Lines        3713     3713           
  Branches     1769     1769           
=======================================
  Hits         1689     1689           
  Misses        803      803           
  Partials     1221     1221           
Flag Coverage Δ
unittests 45.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #918!

@bmagyar
Copy link
Member Author

bmagyar commented Jan 11, 2024

Forgive me mah lord!

@bmagyar bmagyar closed this Jan 11, 2024
@christophfroehlich christophfroehlich deleted the bmagyar-patch-2 branch March 3, 2024 19:24
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
* Add log-level support for spawner node

* Fix check for printing stdout/stderr output from load_parameter_file

* Fix pre-commit errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants