-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jtc: Enable sending trajectories with a partial set of joints #226
jtc: Enable sending trajectories with a partial set of joints #226
Conversation
Hi, thanks for rebasing! Since this is quite a major addition I'd prefer to see Travis being all green about it. As far as I understood @efernandez should have the Travis builds fixed very soon. |
@bmagyar which tests are failing? My connection is a little slow ATM. If it's the jerk test on the diff drive controller, I recommend kicking the test job again or just merge. I'm going to create a PR to disable them for now. |
Finally could see the job output. It seems that something does NOT compile: /home/travis/ros/ws_ros_controls/src/ros_controllers/velocity_controllers/src/joint_position_controller.cpp:241:41: error: ‘struct control_msgs::JointControllerState_<std::allocator<void> >’ has no member named ‘antiwindup’ Maybe this needs to be rebased on top of |
…ests Add tests for velocity_controllers::JointTrajectoryController
Hi @beatrizleon, |
…w-robot/ros_controllers into F_enable_part_traj_kinetic Conflicts: joint_trajectory_controller/CMakeLists.txt
@bmagyar I did the rebase but test is still failing |
Don't worry about that @beatrizleon , that test has been haunting us for a while now...we cannot get it to run properly on travis, everywhere else it runs fine. Upon quadruple-checking the code, I've spotted that the new test file Other than that if you are ok I could merge 👍 |
@bmagyar thanks for spotting that! I updated the copyright info. Let me know if it is ok. I am looking forward to the merge :) |
This took quite a while. Thank you for sticking around and making sure it makes it to the merge! |
Thank you! |
Fixes #182.
This is the same pr as #185 but we rebased it to Kinetic. I have tested it on a docker image and all test are passing. Also commits are compresed just to one.
@bmagyar let us know if this is ok