-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rolling] image_publisher: Fix loading of the camera info parameters on startup #983
Merged
ahcorde
merged 6 commits into
ros-perception:rolling
from
Kotochleb:bugfix/image-publisher-camera-info-startup
May 29, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e9f0774
Fix loading of the camera info parameters on startup
Kotochleb c5ae220
Fix linter errors
Kotochleb c31514d
Else bracket in the same line
Kotochleb 2d58d0e
Apply ament_uncrustify
Kotochleb 149ed41
Remove callback log
Kotochleb 8996ed3
Merge branch 'rolling' into bugfix/image-publisher-camera-info-startup
Kotochleb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you remove these lines the
dowork
method will never be called and the image will be never flippedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timer is set in the
reconfigureCallback
. I didn't want to repeat theCameraInfoManager
block of code inonInit
and did not want to create timer there just to recreate it once again inreconfigureCallback
.