convrnx: reinitialize the raw state between passes #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourairquality
force-pushed
the
conrnx-reinit-raw
branch
from
f3fbcf8 to
4b0d6a4
Compare
|
Note some issues with rtcm conversion too, so updated this PR to also reinitialize rtcm and rinex input stream state between passes. |
ourairquality
force-pushed
the
conrnx-reinit-raw
branch
from
4b0d6a4 to
2e5a96d
Compare
|
Updated for issues with rinex conversion and saved slips. Might want to hold back merging this one to allow more testing, sorry. |
ourairquality
force-pushed
the
conrnx-reinit-raw
branch
from
2e5a96d to
7c0544e
Compare
ourairquality
force-pushed
the
conrnx-reinit-raw
branch
from
7c0544e to
e62f468
Compare
|
You mentioned more testing in your last comment. Do you think this is now ready to merge? |
I have not spotted any further issues here, apart form some issues addressed in subsequent PRs. There is a clear issue this is trying address, the state was not being reset between passes which lead to subtle issues, so need to move forward with some solution here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking another go at this. More data than just the subframes needs to be reset between passes. Rather than adding new reinit fucntions, just free and initialize again.