Fix handling of protected prefixes #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeswr
commented
Sep 28, 2023
Pull Request Test Coverage Report for Build 6472059937
💛 - Coveralls |
jeswr
commented
Sep 28, 2023
jeswr
commented
Sep 28, 2023
|
@rubensworks this is ready for review - I just don't have the permissions to assign you as a reviewer |
rubensworks
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Nice work @jeswr! Aside from the 2 comments, this looks good to me.
jeswr
commented
Oct 10, 2023
|
Thanks! Released as 2.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rubensworks/jsonld-streaming-parser.js#112
Fixes rubensworks/jsonld-streaming-parser.js#117
Supercedes #61.
This has been tested against https://github.com/rubensworks/jsonld-streaming-parser.js. I have additional test cases which I will PR to that library once this patch is released.