Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX ModelAdmin toast elements #424

Merged
merged 1 commit into from
Nov 12, 2023
Merged

FIX ModelAdmin toast elements #424

merged 1 commit into from
Nov 12, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Nov 1, 2023
Closed
@sabina-talipova sabina-talipova force-pushed the pulls/1.13/toast-msg-gridfield branch from 5036e72 to cbf78cf Compare November 1, 2023 22:25
This was referenced Nov 2, 2023
Merged
Merged
GuySartorelli
GuySartorelli requested changes Nov 2, 2023
View reviewed changes
lang/en.yml Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Nov 2, 2023
View reviewed changes
lang/en.yml Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1.13/toast-msg-gridfield branch 2 times, most recently from e041bba to 6a47520 Compare November 3, 2023 00:27
GuySartorelli
GuySartorelli approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will merge when other PRs are all ready to merge.

@sabina-talipova sabina-talipova force-pushed the pulls/1.13/toast-msg-gridfield branch from 6a47520 to c52c166 Compare November 7, 2023 21:47
GuySartorelli
GuySartorelli approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good again. Will merge when other PRs are ready.

GuySartorelli
GuySartorelli approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well locally.

@GuySartorelli GuySartorelli merged commit 62f78a9 into silverstripe:1.13 Nov 12, 2023
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.13/toast-msg-gridfield branch November 12, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli