Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] FIX: update errors properly for remove() #75

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

sandhya-spend
Copy link
Contributor

@sandhya-spend sandhya-spend commented Nov 14, 2024

BUG:

On remove(), state.errros is empty. This is because omitByPrefixes expects a list of paths. Now its corrected.

Added test.

  • Handle errors from array fields

@sandhya-spend sandhya-spend self-assigned this Nov 14, 2024
@decrapifier
Copy link
Contributor

Warnings
⚠️ You should add at least 1 more reviewer to the PR
Messages
📖 We were able to automatically fix some formatting issues in this PR for you!

Coverage Report

👍 Test coverage is looking good.

Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/futil.js 100 100 100 100
src/index.js 100 96.61 96.67 100
src/mobx.js 94.87 88.24 100 94.87 10, 11
and 2 more...
Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/util.js 100 100 100 100
src/validators.js 52.38 100 50 52.38 6, 7, 8, 9, 10, 11, 12, 13, 14, 15

Some things that were possibly fixed:

  • Code that could be fixed via the --fix flag
  • Formatting that could be fixed by prettier

Take a look at this commit to see what happened in detail: 0a458f6

And look at this wiki page to see the reasoning behind the ESLint rules: https://github.com/smartprocure/eslint-config-smartprocure/wiki/Rules-and-Why-We-Chose-Them

Generated by 🚫 dangerJS against 54f7311

@decrapifier
Copy link
Contributor

Warnings
⚠️ You should add at least 1 more reviewer to the PR

Coverage Report

👍 Test coverage is looking good.

Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/futil.js 100 100 100 100
src/index.js 100 96.61 96.67 100
src/mobx.js 94.87 88.24 100 94.87 10, 11
and 2 more...
Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/util.js 100 100 100 100
src/validators.js 52.38 100 50 52.38 6, 7, 8, 9, 10, 11, 12, 13, 14, 15

Generated by 🚫 dangerJS against 0a458f6

@sandhya-spend sandhya-spend changed the title FIX: update errors properly for remove() [DRAFT] FIX: update errors properly for remove() Nov 14, 2024
Copy link
Member

@stellarhoof stellarhoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@stellarhoof stellarhoof merged commit 7c574ae into master Nov 15, 2024
2 checks passed
@stellarhoof stellarhoof deleted the fix/remove_errors branch November 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants