Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jugs closeable, move chemistry entities into chemistry directory #29413

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

jugs closeable, move chemistry entities into chemistry directory #29413

wants to merge 8 commits into from

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Jun 24, 2024 •
edited
Loading

Fixes #24861

About the PR

Jugs could be spilled by mice (was that changed?) and revanents. This prevents that in a way that is player-actionable. i.e skill issue.

Why / Balance

better than just forbidding it imo. But also, consistencey with other containers.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Chemical jugs are now closeable.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

RSI Diff Bot; head commit 6955c5b merging into dfc3562
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Chemistry/jug.rsi

State Old New Status
jug Removed
icon Added
icon_open Added

Edit: diff updated after 6955c5b

@Brandon-Huu
Copy link
Contributor

Brandon-Huu commented Jun 24, 2024 •
edited
Loading

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

@engineer-pearl
Copy link

Bonus: by closing, it is now safer to walk over spills!

@IProduceWidgets
Copy link
Contributor Author

This is gonna be super annoying to deal with. I would rather have my chems spilled then have to deal with opening the jug

If you use a syringe it just works tm.

@thebadman4662
Copy link

thebadman4662 commented Jun 24, 2024 •
edited
Loading

#29139 It will still be possible to dragspill closed jugs so mouse griefers will not fell it compared to what we have now. Revs won't be able to just rightclick it though.
obraz

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

Learn to bottlemed. :trollface:

@Brandon-Huu
Copy link
Contributor

Brandon-Huu commented Jun 24, 2024 •
edited
Loading

This is gonna be super annoying to deal with.
I would rather have my chems spilled then have to deal with opening the jug

Learn to bottlemed. :trollface:

I do

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 2, 2024
@IProduceWidgets IProduceWidgets mentioned this pull request Jul 13, 2024
Open
@IProduceWidgets IProduceWidgets changed the title jugs closeable, move chemitsry entities into chemsitry directory jugs closeable, move chemistry entities into chemsitry directory Jul 18, 2024
@IProduceWidgets IProduceWidgets changed the title jugs closeable, move chemistry entities into chemsitry directory jugs closeable, move chemistry entities into chemistry directory Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 25, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 25, 2024
@IProduceWidgets
Copy link
Contributor Author

Am a little sus because I merged master but didn't need to resolve anything :|

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 18, 2024
@slarticodefast
Copy link
Member

I made a PR that fixes revs and other mobs without hands being able to use the spill verb #31438
Do you think making jugs closeable is still useful regardless of that bug?

@IProduceWidgets
Copy link
Contributor Author

I can't think of any downsides, but honestly I mostly did it because the sprite has a cap already and I found it weird that we didn't add it to them when we added caps since they're the most interacted with container.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 10, 2024
@slarticodefast
Copy link
Member

I gave it a test and I see a few problems:

  • you can still draw from closed jugs with a syringe and transfer via drag and drop, so players will just keep them closed all the time
  • The examine message doesn't clearly show it is closed, which might cause confusion for newer med players
    grafik
  • it is a little hard to distinguish visually
    grafik
  • Mice, revs and other mobs can no longer spill jugs, so the only use this would have is for transport.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@superjj18
Copy link

Small request, hopefully not too far out of scope but can you make captain's flask closable as well?

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. T: New Feature Type: New feature or content, or extending existing content S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 18, 2025
@ilovehans10
Copy link

you can still draw from closed jugs with a syringe and transfer via drag and drop, so players will just keep them closed all the time

How is this a problem?

Mice, revs and other mobs can no longer spill jugs, so the only use this would have is for transport.

How is this a problem?

Sorry for the sarcasm, but both of these seem like major improvements to how things are currently. The whole point of needles is to draw/inject fluids through a membrane. Mice/revs removing tons of work that chemists have put in always feels insanely shitty, and a way to mitigate that would be great.

@insoPL insoPL mentioned this pull request Jan 27, 2025
Open
2 tasks
@insoPL
Copy link
Contributor

insoPL commented Jan 27, 2025

#34683
This PR will fix transfer via drag and drop when jug is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. Merge Conflict P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revs can spill jugs
10 participants
@IProduceWidgets @Brandon-Huu @engineer-pearl @thebadman4662 @slarticodefast @superjj18 @ilovehans10 @insoPL @eoineoineoin @SlamBamActionman