Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drag and drop now checks if container is closed and drainable #34683

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

drag and drop now checks if container is closed and drainable #34683

wants to merge 1 commit into from
+9 −0

Conversation

insoPL
Copy link
Contributor

@insoPL insoPL commented Jan 27, 2025 •
edited
Loading

About the PR

OnRefillableDragged - drag and drop system for solution containers
now checks if container being droped is open and Drainable
Drainable component is defined as:
"Denotes the solution that can be easily removed through any reagent container.
Think pouring this or draining from a water tank."
It makes check for that when drag and dropping container.

You could make closed but empty soda cans using drains which is also goofy.

Why / Balance

Technical details

OnRefillableDragged checks for DrainableComponent and checks if it is open if openable

Media

https://youtube.com/video/waQ_NSvvgt4

Requirements

Breaking changes

Merging #29413 may now make a lot of people angry

Changelog

🆑

  • fix: being able to drag certain food items onto drain and chemmasters

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 27, 2025
@insoPL insoPL marked this pull request as ready for review January 27, 2025 21:14
@insoPL
Copy link
Contributor Author

insoPL commented Jan 27, 2025

Comment your favorite exploit so I know which one I should not fix next time. Bro I swear I won't patch it

@insoPL insoPL mentioned this pull request Jan 27, 2025
Open
1 task
@insoPL insoPL changed the title Small OnRefillableDragged bugfix drag and drop now checks is container is closed and drainable Jan 27, 2025
@insoPL insoPL changed the title drag and drop now checks is container is closed and drainable drag and drop now checks is container if closed and drainable Jan 27, 2025
@insoPL insoPL changed the title drag and drop now checks is container if closed and drainable drag and drop now checks if container is closed and drainable Jan 27, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insoPL @ArtisticRoomba