Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari hat In-hand Sprites #33464

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Safari hat In-hand Sprites #33464

merged 9 commits into from
Dec 12, 2024

Conversation

onesch
Copy link
Contributor

@onesch onesch commented Nov 22, 2024 •
edited
Loading

About the PR

Adds in-hand sprites to the safari hat. based #33386

Why / Balance

Currently it has no in-hands, so this is adding one.

Media

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Nov 22, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

RSI Diff Bot; head commit eab35c0 merging into 842bbeb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/safarihat.rsi

State Old New Status
inhand-left Added
inhand-right Added

Edit: diff updated after eab35c0

@TiniestShark TiniestShark mentioned this pull request Nov 23, 2024
Open
@slarticodefast slarticodefast self-assigned this Dec 11, 2024
@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 11, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Dec 12, 2024 •
edited
Loading

Also a small visual change like this does not need a changelog entry, could you remove that from your PR description?
You will of course still be mentioned in the game's credits for contributing.

@onesch
Copy link
Contributor Author

onesch commented Dec 12, 2024

Also a small visual change like this does not need a changelog entry, could you remove that from your PR description?
You will of course still be mentioned in the game's credits for contributing.

I deleted the changelog.

Is the problem with indents solved? Is the fact that I approved your changes regarding indents already in the branch as a commited?

@slarticodefast
Copy link
Member

It seems like you did not push the changes to your branch correctly, the indentation hasn't been fixed yet.

onesch

This comment was marked as resolved.

Sign in to view

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Dec 12, 2024
slarticodefast
slarticodefast approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contribution!

@slarticodefast slarticodefast merged commit 9d7846e into space-wizards:master Dec 12, 2024
13 checks passed
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
@onesch @Doctor-Cpu
Safari hat In-hand Sprites (space-wizards#33464)
d336e50 
* adds in-hand sprites to the safari hat.

* Update copyright wording

* visual fix

* Resprite in-hand sprites.

* linting meta.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emisse Emisse Emisse approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Awaiting Changes Status: Changes are required before another review can happen size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onesch @slarticodefast @Emisse @beck-thompson