-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Inhand Sprites MegaIssue™ #33386
Comments
Please add #31788 |
Added. Muburu's working on them currently I believe but still useful as a reference point. |
Hello, should I create a pull request for each element separately or take some ready-made bundle and create a pull request? |
It's up to you. Considering inhands are pretty small and specific in nature, I would say it's fine (and even encouraged) to do several at once, especially if they are related in some way. I definitely wouldn't take on the whole list at once or anything, though; The bigger your PR, the more likely it is that something will need to be changed, or that someone else will be working on it. |
Also, to anyone looking at this: I would highly recommend looking for sprites from other SS13 codebases to see if they have suitable inhands before you make them. A lot of the time, SS14 just seems to have.... not ported the original inhand sprites, for no discernible reason. The health analyzer and bola come to mind here. You can use scrubby iconsearch to take a quick search for what you are looking for. Just be mindful that you'll need to actually find what commit the sprite is in yourself, alongside ensuring that the sprite fits the artstyle. |
OMG, well done making such a comprehensive list. This is something I noticed in passing, and will be incredibly useful if I ever get around to working on some of these. Thank you. |
Ooooooo this seems like something fun to wittle away at in my free time. |
I'm thinking on working on some of these now, but before that I've done a little bit of digging to see what's missing from this list. Here's what I've found: Categories:
Syndicate:
Trash/Scrap:
Other:
|
So a few of these I was aware of but deliberately left out since they're relatively small items that I don't personally think need inhands since ultimately they'd end up being a pixel or two. Stuff like the snappops in particular are very very tiny IRL to where it'd just be a single pixel and it's not something needed (especially since most of the time you'd have the box in the other hand and that'd be an easy enough tell). The other stuff though are good catches and it's appreciated! I could have sworn the mouse had an inhand but I guess I was wrong. I'll add most of these to the list but the condiment packets, PDA cartridges, shattered tube and paper scrap I'm going to leave out (Though still feel free to do 'em up! My opinion's definitely not the only one). Also a few of these are already in the list like the sabre sheath and expensive coat but even I forget some of what's here so it's all good Also also: Some of the things listed do already have inhands like the Firelock Frame scrap. |
Description
There's many items in the game currently lacking any form of Inhand sprites and just appear invisible when held. While not exactly a high priority, fixing and adding inhands to many of these will help with general immersion and visibility.
This is by no means entirely comprehensive (I am one human being) and if there's any I missed, please let me know. Some items were grouped together that could be solved with a generic inhand for their particular category. (I'm also not including items there are already open or already merged PRs for)
I'll update this as PRs are added, Food/Drinks/Plants will be their own issue at some point (Just assume its all of them)
Item Groups:
Clothing:
Dishes/Utencils:
Instruments:
Materials:
Medical:
Plushies/Toys:
Tools/Devices:
Trash/Scrap:
Syndicate/Criminal Items:
Weapons/Ammo:
Other:
The text was updated successfully, but these errors were encountered: