Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elf Ears #33572

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Elf Ears #33572

merged 3 commits into from
Feb 5, 2025

Conversation

Farrellka-dev
Copy link
Contributor

@Farrellka-dev Farrellka-dev commented Nov 26, 2024 •
edited
Loading

About the PR

I hate those ears - #30490.
So I added different variations of long (elf) ears.
<(-w-)>

Why / Balance

It's simple, I hate these ears in this PR - #30490.
These ears look like a yellow crop of something, but not ears in any way, so I added 6 variations of long ears.
Oh, and I also love elves very much, if I may, I can make them, with their own characteristics, like dwarves.

Technical details

I just added more variations of long ears. Just pictures, just meta, just prototypes and translations. Nothing special.

Media

It was before me:
image
An example of one of my ears:
image
More ears here:
image

Requirements

Breaking changes

Changelog

🆑 Farrellka

  • remove: Removed the old long ears for human!
  • add: Added more long (elf) ears for human!

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

RSI Diff Bot; head commit db00126 merging into d5225d1
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/ears.rsi

State Old New Status
long_ears Removed
long_ears_small Added
long_ears_standard Added
long_ears_tall Added
long_ears_thin Added
long_ears_upwards Added
long_ears_wide Added

Edit: diff updated after db00126

@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 26, 2024
@ps3moira
Copy link
Contributor

Just replace the original since the original doesn't look too good

@Farrellka-dev
Copy link
Contributor Author

I do not know if I have the right to have his ears removed.

@Farrellka-dev
Copy link
Contributor Author

Farrellka-dev commented Nov 27, 2024 •
edited
Loading

Random error, lmao.
Test fail unrelated to PR.

@Farrellka-dev Farrellka-dev mentioned this pull request Dec 17, 2024
Merged
2 tasks
@Farrellka-dev Farrellka-dev mentioned this pull request Feb 4, 2025
Closed
2 tasks
@beck-thompson beck-thompson self-assigned this Feb 4, 2025
beck-thompson
beck-thompson requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs art approval I'll ask about that 🫡

Resources/Prototypes/Entities/Mobs/Customization/Markings/ears.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/ears.yml Show resolved Hide resolved
@beck-thompson beck-thompson added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 4, 2025
@Emisse
Copy link
Contributor

Emisse commented Feb 4, 2025

art approval

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Feb 5, 2025
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Feb 5, 2025
@github-actions github-actions bot removed the S: Awaiting Changes Status: Changes are required before another review can happen label Feb 5, 2025
beck-thompson
beck-thompson approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ball... If people end thinking some look weird for humans we can always revert those specific ones. I really can't make any judgement calls but I think they are all mostly fine 😆

@beck-thompson beck-thompson merged commit d0bdbc8 into space-wizards:master Feb 5, 2025
15 checks passed
@Farrellka-dev Farrellka-dev deleted the elf_ears branch February 5, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emisse Emisse Emisse approved these changes

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees

@beck-thompson beck-thompson

Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Farrellka-dev @ps3moira @Emisse @beck-thompson @ScarKy0