Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools/Devices: In-hand Sprites #33689

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

onesch
Copy link
Contributor

@onesch onesch commented Dec 2, 2024

About the PR

Adds in-hand sprites to the floodlight, gas-analyzer, gps, mass-scanner, scissors and spray-painter. Based #33386
[updated: 02.01.2025]

Why / Balance

Currently it has no in-hands, so this is adding one.

Technical details

slightly changed .yml and meta.json

Media



Requirements

Breaking changes

Changelog

🆑 onesch

  • add: Added handheld sprites to some items

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

RSI Diff Bot; head commit 5bda80d merging into a033abb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/gps.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Misc/Lights/lights.rsi

State Old New Status
floodlight-broken-inhand-left Added
floodlight-broken-inhand-right Added
off-inhand-left Added
off-inhand-right Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/Objects/Specific/Atmos/gasanalyzer.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/handheld_mass_scanner.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/scissors.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/spray_painter.rsi

State Old New Status
inhand-left Added
inhand-right Added

Edit: diff updated after 5bda80d

@lzk228
Copy link
Contributor

lzk228 commented Dec 2, 2024

there is no need for that big cl
you can collapse it to just "Added handheld sprites to some items"

@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 2, 2024
@TiniestShark
Copy link
Contributor

My only issues are with the handheld mass scanner and gas analyzer personally. They feel too small compared to the other tools.

@onesch
Copy link
Contributor Author

onesch commented Dec 3, 2024

My only issues are with the handheld mass scanner and gas analyzer personally. They feel too small compared to the other tools.

Are you saying that it's possible to make even smaller sprites for them?

@TiniestShark
Copy link
Contributor

Are you saying that it's possible to make even smaller sprites for them?

Nah I mean the gas analyzer and handheld mass scanner should feel bigger than the sprites currently portray them. I did a similar thing with the first version of my anomaly scanner and after comparisons the bigger size fits it much better.

@onesch
Copy link
Contributor Author

onesch commented Dec 4, 2024

Nah I mean the gas analyzer and handheld mass scanner should feel bigger than the sprites currently portray them. I did a similar thing with the first version of my anomaly scanner and after comparisons the bigger size fits it much better.

will you show me?

@TiniestShark
Copy link
Contributor

will you show me?

Sure! I did a very similar build for my first anom scanner inhand
scanner example

It's kind of needlessly small in hindsight compared to the actual look of the device's icon. The purple screen on my sprite is too boxy compared to the rectangular portion, the satellite dish is only a single sprite, and the smaller profile makes it harder to read as the anomaly scanner, it ends up looking closer to the Emag or something. I was worried that going bigger would look worse than too small but.

scanner example 2
The new one is based off the health analyzer from TG which is roughly the same size on the inhand and icon. The bigger size allows for just enough detail to evoke the icon far better, giving the screen more space, so it has a much more natural looking coloration, adding just two extra pixels to make the dish look look more like...well, an actual dish, and reducing the size of the purple grip a bit since it would be the part being held anyway.

So long as the sprites dont go over each other if you're holding them in both hands, it's perfectly fine to go bigger with the inhands so they can better emulate the icon (plus some stuff like the Gas Analyzer has a larger icon so one would expect the inhand to be bigger as well). Better to overshoot and make it too big than cut it short imo (i say despite forgetting that exact thing), ends up being an easier problem to fix as well.

@onesch
Copy link
Contributor Author

onesch commented Dec 5, 2024

@TiniestShark
what about gas analyzer and mass scanner? how can it be made bigger¿
maybe you have ready sprites of them?

@TiniestShark
Copy link
Contributor

@TiniestShark what about gas analyzer and mass scanner? how can it be made bigger¿ maybe you have ready sprites of them?

Let me take a crack at an example, I'll get something soon.

@TiniestShark
Copy link
Contributor

@TiniestShark what about gas analyzer and mass scanner? how can it be made bigger¿ maybe you have ready sprites of them?

Admittedly my sprite/art capabilities are still pretty wanting but a rough mockup like this i think kind of shows the direction to go for.

image

@onesch
Copy link
Contributor Author

onesch commented Dec 7, 2024

Admittedly my sprite/art capabilities are still pretty wanting but a rough mockup like this i think kind of shows the direction to go for.

I tried to do something similar but decided to keep the current version based on the style of other sprites in the game.

your example looks good, I liked the one at the top left, but if you compare the "sizes" of this sprite, isn't it similar to the size of the character's head?

@TiniestShark
Copy link
Contributor

your example looks good, I liked the one at the top left, but if you compare the "sizes" of this sprite, isn't it similar to the size of the character's head?

Similar yes, but a lot of the sprites in the game operate on some level of scale dissociation. The gas analyzer in particular has a pretty big icon and I feel should at least look a bit bigger in hand with the amount of information it needs to convey on the screen as well (especially when compared to something like the multitool).

@onesch
Copy link
Contributor Author

onesch commented Dec 17, 2024

Similar yes, but a lot of the sprites in the game operate on some level of scale dissociation. The gas analyzer in particular has a pretty big icon and I feel should at least look a bit bigger in hand with the amount of information it needs to convey on the screen as well (especially when compared to something like the multitool).

let's ask the design leader what's best

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Dec 21, 2024
@onesch onesch changed the title Tools/Devices: In-hand Sprites [part-1] Tools/Devices: In-hand Sprites [updated 21/12/24] Dec 21, 2024
@onesch onesch changed the title Tools/Devices: In-hand Sprites [updated 21/12/24] Tools/Devices: In-hand Sprites [updated 21.12.24] Dec 21, 2024
@onesch onesch changed the title Tools/Devices: In-hand Sprites [updated 21.12.24] Tools/Devices: In-hand Sprites Dec 22, 2024
@TiniestShark
Copy link
Contributor

Forgot to chime in after the @ you sent me, spray painter looks good! I also like the update to the mass scanner, very nice.

@onesch
Copy link
Contributor Author

onesch commented Jan 1, 2025

Forgot to chime in after the @ you sent me, spray painter looks good! I also like the update to the mass scanner, very nice.

I'm interested in your opinion, which one is better?

@TiniestShark
Copy link
Contributor

I'm interested in your opinion, which one is better?

I'd say the first one personally. The longer one looks much closer to the base sprite, and I think you did a good job conveying its features.

@onesch
Copy link
Contributor Author

onesch commented Jan 18, 2025

my pull request was abandoned?

@TiniestShark
Copy link
Contributor

my pull request was abandoned?

nah, inhands are just a minor priority right now and there's like, almost 700 pull requests that the maintainers are evaluating and discussing at any given time. Long as it's open it'll get evaluated at some point, just might take a while is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants