Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inhand sprites for the pride pins #34216

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

momochitters
Copy link

About the PR

Adds in-hand sprites for the pride pins.

Why / Balance

As said in the MegaIssue™ below, "There's many items in the game currently lacking any form of Inhand sprites and just appear invisible when held. While not exactly a high priority, fixing and adding inhands to many of these will help with general immersion and visibility."
#33386

Technical details

  • Edits pins.yml and the texture's meta.json file.
  • Adds left and right inhand textures for each pride pin.

Media

Screenshot 2025-01-04 162233
Screenshot 2025-01-04 162917
Screenshot 2025-01-04 162816

Requirements

Changelog

None, due to this PR not affecting gameplay.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 4, 2025
Copy link
Contributor

github-actions bot commented Jan 4, 2025

RSI Diff Bot; head commit c42d170 merging into fa020ce
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Neck/Misc/pins.rsi

State Old New Status
ally-inhand-left Added
ally-inhand-right Added
aro-inhand-left Added
aro-inhand-right Added
asex-inhand-left Added
asex-inhand-right Added
autism-inhand-left Added
autism-inhand-right Added
bi-inhand-left Added
bi-inhand-right Added
gay-inhand-left Added
gay-inhand-right Added
gender-inhand-left Added
gender-inhand-right Added
goldautism-inhand-left Added
goldautism-inhand-right Added
inter-inhand-left Added
inter-inhand-right Added
les-inhand-left Added
les-inhand-right Added
lgbt-inhand-left Added
lgbt-inhand-right Added
non-inhand-left Added
non-inhand-right Added
omni-inhand-left Added
omni-inhand-right Added
pan-inhand-left Added
pan-inhand-right Added
trans-inhand-left Added
trans-inhand-right Added

Edit: diff updated after c42d170

@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 4, 2025
@TiniestShark
Copy link
Contributor

Look just about the right size I'd say, nice work! Updated the megaissue thread with this.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants