-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inhand sprites for the pride pins #34216
Open
momochitters
wants to merge
8
commits into
space-wizards:master
Choose a base branch
from
momochitters:inhands
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSI Diff Bot; head commit c42d170 merging into fa020ce Resources/Textures/Clothing/Neck/Misc/pins.rsi
|
Look just about the right size I'd say, nice work! Updated the megaissue thread with this. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: Art
Area: Art with no implications for other areas.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
Changes: Sprites
Changes: Might require knowledge of spriting or visual design.
DB: Beginner Friendly
Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result.
P3: Standard
Priority: Default priority for repository items.
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/M
Denotes a PR that changes 100-999 lines.
T: Visual Change
Type: Deals with changes to art, sprites or other visuals in the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds in-hand sprites for the pride pins.
Why / Balance
As said in the MegaIssue™ below, "There's many items in the game currently lacking any form of Inhand sprites and just appear invisible when held. While not exactly a high priority, fixing and adding inhands to many of these will help with general immersion and visibility."
#33386
Technical details
pins.yml
and the texture'smeta.json
file.Media
Requirements
Changelog
None, due to this PR not affecting gameplay.