-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add In-Hand Sprites to the Snapop Box and Decoy Balloons #34964
base: master
Are you sure you want to change the base?
Conversation
RSI Diff Bot; head commit d02de19 merging into 543b482 Resources/Textures/Objects/Fun/toys.rsi
Resources/Textures/Objects/Tools/Decoys/agent_decoy.rsi
Resources/Textures/Objects/Tools/Decoys/commander_decoy.rsi
Resources/Textures/Objects/Tools/Decoys/elite_decoy.rsi
Resources/Textures/Objects/Tools/Decoys/juggernaut_decoy.rsi
Resources/Textures/Objects/Tools/Decoys/operative_decoy.rsi
|
Looks good! More inhands are definitely always a plus. Might be worth seeing if you can add some colored pixels to the centers of the boxes so they stand out individually rather than each of them being relatively similar. |
I was gonna say something about every box using the default sprite, but then I remembered that these are like 15 pixels large, so I made one for all 6 boxes. |
Yee, unless they're all in one folder sharing the same sprite, its better to make sure they're as distinct as possible so people can clearly parse what it is. The colors look much better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprites need attribution, you should probably post some images to let us know that all of the inhands work.
I think that's it? I've added attributions to all sprites and added two more images of proof that it works. |
Resources/Textures/Objects/Tools/Decoys/agent_decoy.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Tools/Decoys/commander_decoy.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Tools/Decoys/elite_decoy.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Tools/Decoys/juggernaut_decoy.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Tools/Decoys/operative_decoy.rsi/meta.json
Outdated
Show resolved
Hide resolved
ok for real this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me and the changes appear to work in the screenshots, I haven't given it a test though so I can't say for sure. My primary concern is the weird inhands naming causing all of the inhands to display the same thing.
Sprites will require art maintainer approval and of course an actual maintainer will have to properly review the yaml/json side as well.
About the PR
The Snappop Box and the Decoy Balloon have been given in-hand sprites based on the default box sprite.
Both my first PR and first step to contributing to #33386
Why / Balance
Every other box has the same in-hand sprite, the same should apply to these two.
Technical details
Nothing Special, went off of other PRs that added/modified in-hand sprites.
Media
More proof:

Requirements
Changelog