Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Item In-Hand Sprites #34984

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Medical Item In-Hand Sprites #34984

wants to merge 15 commits into from

Conversation

SeamLesss
Copy link

@SeamLesss SeamLesss commented Feb 9, 2025 •
edited
Loading

About the PR

Added In-hand sprites for the following items:

  • Gauze
  • Bruise Packs
  • Tourniquet
  • Blood Bag
  • Body Bag
  • Handheld Crew Monitor
  • Health Analyzer
  • Roller Beds
  • Implanters
  • Syndicate Implanters
  • Medipens

Why / Balance

More In-hand Sprites the better, plus these are used frequently in medical gameplay.
Contributes to #33386

Technical details

Same as other PRs that add in-hand sprites, but the bruise pack sprite was actually already in-game, just never used.

Media

Screenshot 2025-02-10 180431

Screenshot 2025-02-10 180447

Screenshot 2025-02-10 180507

Screenshot 2025-02-10 180544

Requirements

Changelog

🆑 Seam_Less

  • add: Added in-hand sprites to many common medical items that previously lacked one.
  • fix: Fixed the bruise pack using the ointment in-hand sprite instead of it's own sprite.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 9, 2025
@SeamLesss SeamLesss changed the title Medial Item In-Hand Sprites Medcial Item In-Hand Sprites Feb 9, 2025
@SeamLesss SeamLesss changed the title Medcial Item In-Hand Sprites Medical Item In-Hand Sprites Feb 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

RSI Diff Bot; head commit 413f837 merging into 862a2a7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Medical/medipen.rsi

State Old New Status
medipen-inhand-left Modified
medipen-inhand-right Modified
arithpen-inhand-left Added
arithpen-inhand-right Added
bicpen-inhand-left Added
bicpen-inhand-right Added
dermpen-inhand-left Added
dermpen-inhand-right Added
dexpen-inhand-left Added
dexpen-inhand-right Added
hypovolemic-inhand-left Added
hypovolemic-inhand-right Added
morphen-inhand-left Added
morphen-inhand-right Added
penacid-inhand-left Added
penacid-inhand-right Added
punctpen-inhand-left Added
punctpen-inhand-right Added
pyrapen-inhand-left Added
pyrapen-inhand-right Added
stimpen-inhand-left Added
stimpen-inhand-right Added

Resources/Textures/Objects/Specific/Medical/Morgue/bodybags.rsi

State Old New Status
bag-inhand-left Added
bag-inhand-right Added

Resources/Textures/Objects/Specific/Medical/handheldcrewmonitor.rsi

State Old New Status
scanner-inhand-left Added
scanner-inhand-right Added

Resources/Textures/Objects/Specific/Medical/healthanalyzer.rsi

State Old New Status
analyzer-inhand-left Added
analyzer-inhand-right Added

Resources/Textures/Objects/Specific/Medical/implanter.rsi

State Old New Status
implanter-inhand-left Added
implanter-inhand-right Added

Resources/Textures/Objects/Specific/Medical/medical.rsi

State Old New Status
bloodpack-inhand-left Added
bloodpack-inhand-right Added
gauze-inhand-left Added
gauze-inhand-right Added
tourniquet-inhand-left Added
tourniquet-inhand-right Added

Resources/Textures/Objects/Specific/Medical/syndi_implanter.rsi

State Old New Status
implanter-inhand-left Added
implanter-inhand-right Added

Resources/Textures/Structures/Furniture/rollerbeds.rsi

State Old New Status
cheap_rollerbed-inhand-left Added
cheap_rollerbed-inhand-right Added
emergency_rollerbed-inhand-left Added
emergency_rollerbed-inhand-right Added
rollerbed-inhand-left Added
rollerbed-inhand-right Added

Edit: diff updated after 413f837

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Feb 9, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Feb 9, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Feb 12, 2025
@SeamLesss SeamLesss marked this pull request as ready for review February 12, 2025 03:33
@TiniestShark TiniestShark mentioned this pull request Feb 8, 2025
Open
@TiniestShark
Copy link
Contributor

Added these to the master, really solid work!

ArtisticRoomba
ArtisticRoomba suggested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some messed up spacing in some JSONs.

All new sprites also need attribution.

Resources/Textures/Objects/Specific/Medical/syndi_implanter.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Structures/Furniture/rollerbeds.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Structures/Furniture/rollerbeds.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Structures/Furniture/rollerbeds.rsi/meta.json Outdated Show resolved Hide resolved
@SeamLesss
Copy link
Author

Fixed!

ArtisticRoomba
ArtisticRoomba suggested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing is still messed up in some places, and some attribution stuff needs fixing

Resources/Textures/Objects/Specific/Medical/Morgue/bodybags.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Objects/Specific/Medical/handheldcrewmonitor.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Objects/Specific/Medical/handheldcrewmonitor.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Objects/Specific/Medical/healthanalyzer.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Objects/Specific/Medical/implanter.rsi/meta.json Outdated Show resolved Hide resolved
Resources/Textures/Objects/Specific/Medical/medipen.rsi/meta.json Outdated Show resolved Hide resolved
@SeamLesss
Copy link
Author

I think that fixed it?

ArtisticRoomba
ArtisticRoomba suggested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing!

Resources/Textures/Objects/Specific/Medical/Morgue/bodybags.rsi/meta.json Outdated Show resolved Hide resolved
@SeamLesss
Copy link
Author

Idk what I did but I think it's fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtisticRoomba ArtisticRoomba ArtisticRoomba requested changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeamLesss @TiniestShark @ArtisticRoomba