fix: ci.yml remove unused stuff #10
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @giladchase)
.github/workflows/ci.yml line 101 at r1 (raw file):
all-tests:
I checked previous PRs, and I see that this job was skipped.
Interesting! What does this job do?
Code quote:
all-tests:
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)
.github/workflows/ci.yml line 101 at r1 (raw file):
Previously, MohammadNassar1 (mohammad-starkware) wrote…
I checked previous PRs, and I see that this job was skipped.
Interesting! What does this job do?
looks like it's used for jobs that depend on other jobs, which we don't have.
Also, the repo of this action appears to be abandoned (no updates in two years), and has only 90 stars, so I'm not sure about adding it to our CI.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
- merge_group isn't relevant - no python tests here - not sure why we need all-tests commit-id:6e45706e
giladchase
force-pushed
the
spr/main/6e45706e
branch
from
12d3f22 to
0884ebd
Compare
Stack:
This change is