fix: fix compilation by fixing crates structure #7
Conversation
Also add lints and metadata commit-id:1a9f43aa
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @giladchase)
Cargo.toml line 9 at r1 (raw file):
edition = "2021" repository = "https://github.com/starkware-libs/mempool/" license = "Apache-2.0"
Why you didnt add:
license-file = "LICENSE"
Code snippet:
license-file = "LICENSE"
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)
Cargo.toml line 9 at r1 (raw file):
Previously, MohammadNassar1 (mohammad-starkware) wrote…
Why you didnt add:
license-file = "LICENSE"
Not necessary if we're using a standard license like Apache-2.0 --- if you remember, when you publish the blockifier it whined about having both a standard license and license-file.
However, we should still have a LICENSE file i think, for github, which AFAICS requires it, so i added it on top of the stack.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
Also add lints and metadata
Stack:
This change is