fix: add rustfmt/clippy scripts to make CI pass #9
Conversation
commit-id:241c09e5
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @giladchase)
scripts/clippy.sh line 3 at r1 (raw file):
#!/bin/bash cargo clippy "$@" --all-targets --all-features
Add?
-D warnings -D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)
scripts/clippy.sh line 3 at r1 (raw file):
Previously, MohammadNassar1 (mohammad-starkware) wrote…
Add?
-D warnings -D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused
Not necessary, they're automatically added due to the lints section in Cargo.toml
Not sure why we have them in the blockifier.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
Stack:
This change is