-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use rich printer for init #1548
Feat/use rich printer for init #1548
Conversation
2dd1fbc
to
1d22954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some nits, but in general I think that we should have a the root command handle the print.errorln
of the errors. The map_err's with print.errorln
here are providing context to the error and should be an error case so that the caller would have that context.
@willemneal that's a good point - instead of printing the error messages and then swallowing the errors, we should return the error for those cases. I can work on that change in a separate PR. |
e1a33c7
to
4da9a8d
Compare
What
Refactor
contract init
command to usesoroban-cli/src/print.rs
.Closes #1553
Why
To be more consistent without our output, and to reduce duplication.
Known limitations
n/a