-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch & flatten the latest published version of external portal data when publishing the parent flow #2783
fix: fetch & flatten the latest published version of external portal data when publishing the parent flow #2783
Conversation
Removed vultr server and associated DNS entries |
…ss/fetch-published-portals-on-publish
…ss/fetch-published-portals-on-publish
…/unpublished & /publish-preview routes from frontend
…ss/fetch-published-portals-on-publish
editor.planx.uk/src/pages/FlowEditor/components/PreviewBrowser.tsx
Outdated
Show resolved
Hide resolved
…ss/fetch-published-portals-on-publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a good play around with this and all is working as expected on Pizza ✅
|
…ss/fetch-published-portals-on-publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good thanks!
…ss/fetch-published-portals-on-publish
…ss/fetch-published-portals-on-publish
…ss/fetch-published-portals-on-publish
…theopensystemslab/planx-new into jess/fetch-published-portals-on-publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed routing changes ✅
…latest version is always flattened and not old snapshot (#2839)
We're changing the rules of how we "publish" flows:
/preview
(next →/published
) - the latest published version of the parent flow/amber
(next →/preview
) - the draft of the parent, plus the latest published version of each external portal/draft
- the draft of the parent, plus the draft of each external portalplatformAdmin
Key code changes:
dataMerged
flattening logic (incl tests) in the API ONLY and removes the duplicate definition from the Editor/flow/:flowId/flatten-data
(incl tests and Swagger doc) that can be called by the Editor views/amber
&/draft
instead of relying on the duplicate definition ofdataMerged
validateAndDiff
&publish
to reflect new rules and error handling, and draw from consistent mock datadraft
,preview
,published
)Testing notes:
/published
loads published flow and published external portal data/preview
redirects to/published
/amber
loads draft flow and published external portal data/unpublished
redirects to/draft
/draft
loads draft flow and draft external portal dataFuture scope:
/amber
→/preview
after ~30 days (will set Slack channel reminder)