Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): continue button should always be enabled on FindProperty & DrawBoundary #3022

Closed
wants to merge 5 commits into from
Closed

fix(a11y): continue button should always be enabled on FindProperty & DrawBoundary #3022

wants to merge 5 commits into from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Apr 16, 2024 •
edited
Loading

WIP

Ideas / questions / todos:

  • Error handling for postcode input & address autocomplete
    • Can we conditionally render address autocomplete still or should we always show a disabled select until valid postcode?
  • How to error handle supplemental data fetch that FindPropery does? Wrap continue button in error if loading spinner still visible?
  • ErrorWrapper for maps (Plot new address & draw boundary)
  • ErrorWrapper for location plan upload (re-use FileUpload validation schema?)

@jessicamcinchak
Copy link
Member Author

Status messages [AA]

@jessicamcinchak
Copy link
Member Author

Disabled buttons and unexpected input functionality [Usability]

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak mentioned this pull request May 9, 2024
Merged
@jessicamcinchak jessicamcinchak changed the title fix(a11y): continue button should always be enabled on FindProperty fix(a11y): continue button should always be enabled on FindProperty & DrawBoundary May 9, 2024
@ianjon3s ianjon3s mentioned this pull request May 10, 2024
Merged
@jessicamcinchak jessicamcinchak mentioned this pull request May 10, 2024
Merged
@jessicamcinchak
Copy link
Member Author

Closing in favor of smaller per-component PRs linked here https://trello.com/c/elmTB1Pq/2828-disabled-buttons-and-unexpected-input-functionality-usability

@jessicamcinchak jessicamcinchak deleted the jess/findproperty-a11y branch May 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jessicamcinchak