Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove old Settings component and routes #3409

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore: Remove old Settings component and routes #3409

merged 1 commit into from
Jul 12, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 11, 2024 •
edited
Loading

What does this PR do?

  • Remove Settings component - this was a wrapper which controlled the settings pages via tabs, and is no longer used
  • Remove routes/teamSettings.tsx and routes/flowSettings.tsx - redundant as we're no longer prefixing URLs with /settings
  • Failing E2E test addressed in chore: Remove additional options from dropdown menu #3408 which should be merged first, then I'll rebase this PR

@DafyddLlyr DafyddLlyr changed the base branch from main to ian/editor-navigation-menus July 11, 2024 11:06
@DafyddLlyr DafyddLlyr marked this pull request as ready for review July 11, 2024 11:08
@DafyddLlyr DafyddLlyr requested a review from a team July 11, 2024 11:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr marked this pull request as draft July 11, 2024 13:43
@DafyddLlyr DafyddLlyr force-pushed the ian/editor-navigation-menus branch from c6ea914 to d9ffda6 Compare July 11, 2024 14:24
@DafyddLlyr DafyddLlyr force-pushed the dp/remove-old-settings-components-and-routes branch from 2437807 to 9587e55 Compare July 11, 2024 14:26
@DafyddLlyr DafyddLlyr mentioned this pull request Jul 12, 2024
Merged
@DafyddLlyr DafyddLlyr force-pushed the ian/editor-navigation-menus branch from d9ffda6 to 6f03ea0 Compare July 12, 2024 09:42
@DafyddLlyr DafyddLlyr force-pushed the dp/remove-old-settings-components-and-routes branch from 9587e55 to d58614d Compare July 12, 2024 09:44
@DafyddLlyr DafyddLlyr force-pushed the dp/remove-old-settings-components-and-routes branch from d58614d to 1a6c03f Compare July 12, 2024 12:05
@DafyddLlyr DafyddLlyr mentioned this pull request Jul 12, 2024
Merged
7 tasks
@DafyddLlyr DafyddLlyr requested a review from a team July 12, 2024 12:21
@DafyddLlyr DafyddLlyr marked this pull request as ready for review July 12, 2024 12:21
@DafyddLlyr DafyddLlyr merged commit 3cd5691 into ian/editor-navigation-menus Jul 12, 2024
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/remove-old-settings-components-and-routes branch July 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s