Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wip): Navigation from search #3460

Closed
wants to merge 8 commits into from
Closed

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 26, 2024

⚠️ Rough and incomplete (very much a work in progress!), hoping to tidy up a little before show and tell

Screen.Recording.2024-07-26.at.08.38.52.mov

To do...

  • Tests!
  • Handle internal portals
  • Handle nodes with _root in path
  • Handle all node types
  • Tidy up code

Copy link

github-actions bot commented Jul 26, 2024

Pizza

Deployed acb4cb6 to https://3460.planx.pizza.

Useful links:

@DafyddLlyr DafyddLlyr force-pushed the dp/get-url-for-node branch from 49eec4b to 94198d8 Compare July 29, 2024 10:33
DafyddLlyr added a commit to theopensystemslab/planx-core that referenced this pull request Jul 29, 2024
## What does this PR do?
- Generates a path for a node, which is required for search
- Relies on #462
- Implemented in
theopensystemslab/planx-new#3460
Base automatically changed from dp/fuse-js to main July 30, 2024 11:27
@DafyddLlyr DafyddLlyr marked this pull request as draft July 30, 2024 12:25
@DafyddLlyr
Copy link
Contributor Author

Closed in order to tidy up PR list, will cherry-pick 94198d8 onto another branch when I return to this shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant