Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Taco application to dashboard #625

Merged
merged 122 commits into from
Dec 19, 2023
Merged

Add Taco application to dashboard #625

merged 122 commits into from
Dec 19, 2023

Conversation

theref
Copy link
Member

@theref theref commented Sep 22, 2023 •
edited
Loading

Builds on top of #624

Fixes #678 #680 #675 #673

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@theref theref mentioned this pull request Sep 23, 2023
Closed
@theref theref requested review from KPrasch and cygnusv September 23, 2023 08:20
@manumonti manumonti self-requested a review October 11, 2023 08:44
manumonti
manumonti previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great work 🙌

What is the plan with the TODOs created in commit #7eb5030? Are you planning to address them in other PR?

src/pages/Staking/HowItWorks/StakingApplications/index.tsx Show resolved Hide resolved
src/components/Modal/MapOperatorToStakingProviderConfirmationModal/index.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

1 similar comment
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

derekpierre
derekpierre reviewed Oct 11, 2023
View reviewed changes
src/components/Modal/MapOperatorToStakingProviderConfirmationModal/index.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/StakingApplicationOperationIcon/index.tsx Outdated Show resolved Hide resolved
src/enums/externalHref.ts Outdated Show resolved Hide resolved
src/pages/Staking/HowItWorks/StakingApplications/index.tsx Outdated Show resolved Hide resolved
src/pages/Staking/HowItWorks/StakingApplications/index.tsx Outdated Show resolved Hide resolved
src/threshold-ts/mas/index.ts Outdated Show resolved Hide resolved
src/types/rewards.ts Outdated Show resolved Hide resolved
src/types/staking.ts Outdated Show resolved Hide resolved
src/utils/__tests__/getStakingAppLabel.test.ts Show resolved Hide resolved
derekpierre
derekpierre reviewed Oct 11, 2023
View reviewed changes
.env.production Outdated Show resolved Hide resolved
@theref theref force-pushed the taco branch 2 times, most recently from 8024425 to 5e05a15 Compare October 12, 2023 10:27
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

3 similar comments
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@theref theref marked this pull request as draft October 16, 2023 13:57
@theref theref force-pushed the taco branch 2 times, most recently from c25dfe3 to aa56beb Compare October 17, 2023 16:05
@theref theref marked this pull request as ready for review October 18, 2023 10:01
@theref theref force-pushed the taco branch 3 times, most recently from 665a0e5 to f050643 Compare October 18, 2023 11:27
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

3 similar comments
@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@github-actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

theref and others added 14 commits December 19, 2023 14:17
@theref
refactor: improve form validation logic for staking app authorization
917ac03
@theref
Address UI improvements in TACo commitment modal
c8cd164
@theref
Move TBTC+RB alert inside conditional statement and improve condition
e2c8e4b
@theref
Reset validateInputtedOperatorAddress to match main
769fa45
@theref
Redo OperatorMapping logic to handle variety of apps
ef47fdb
@theref @michalsmiarowski
Update src/components/Modal/MapOperatorToStakingProviderModal/index.tsx
4356900 
Co-authored-by: Michał Śmiarowski <[email protected]>
@theref @michalsmiarowski
Update src/components/Modal/MapOperatorToStakingProviderModal/index.tsx
a26ec0d 
Co-authored-by: Michał Śmiarowski <[email protected]>
@theref
Fix logical comparison for tbtc and rb
0874145
@theref
Fix conditional rendering of tbtc and rb label
6409c6c
@theref
Add success modal to TACo commitment
e1a53ca
@theref
Show TACo commitment button only if TACo isAuthorized
c62b5aa
@theref
Refactor variable for assessing which apps have operator mapped
69c9ad4
@theref @michalsmiarowski
Update src/components/Modal/MapOperatorToStakingProviderModal/index.tsx
46e0a12 
Co-authored-by: Michał Śmiarowski <[email protected]>
@theref @michalsmiarowski
Update src/components/Modal/MapOperatorToStakingProviderModal/index.tsx
a188adf 
Co-authored-by: Michał Śmiarowski <[email protected]>
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

2 similar comments
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@michalsmiarowski michalsmiarowski self-requested a review December 19, 2023 14:27
cygnusv
cygnusv approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after the rebase due to the need of signed commits. As seen here, https://github.com/threshold-network/token-dashboard/compare/524f0b8b2b07f1f57343a061820954fb9579c525..a188adf344fced8ef2c17cce9c594ac6052e79d2, no actual changes happened

michalsmiarowski
michalsmiarowski approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding approve again after rebase to make all commits verified 👍

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.dashboard.test.threshold.network/taco/index.html.

@cygnusv cygnusv merged commit cd39b87 into main Dec 19, 2023
10 checks passed
@cygnusv cygnusv deleted the taco branch December 19, 2023 14:36
@theref theref added this to the v1.14.0 milestone Dec 19, 2023
This was referenced Dec 20, 2023
Closed
Closed
Closed
This was referenced Dec 21, 2023
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekpierre derekpierre derekpierre left review comments

@michalsmiarowski michalsmiarowski michalsmiarowski approved these changes

@therealsphinx therealsphinx therealsphinx approved these changes

@cygnusv cygnusv cygnusv approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@manumonti manumonti Awaiting requested review from manumonti

@lukasz-zimnoch lukasz-zimnoch Awaiting requested review from lukasz-zimnoch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

TACo specific Operator Bonding
8 participants
@theref @cygnusv @derekpierre @therealsphinx @manumonti @michalsmiarowski @KPrasch @piotr-roslaniec