Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move localization, vehicle, and control tools to the autoware_tools repository #162

Merged

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Apr 18, 2024

Description

Follow This discussion, I move localization, vehicle, control tool to autoware_tools

In this PR, I remove these tools and msg.

autoware_tools PR

I checked colcon build is success and sensor calibration launch test.
I launched below command and I tested some calibration tools
ex) LiDAR - Camera

ros2 run sensor_calibration_manager sensor_calibration_manager

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25 knzo25 changed the title feat: move localiztion, vehicle, control tool to autoware_tools repojitory feat: move localization, vehicle, and control tools to the autoware_tools repository Apr 18, 2024
@yabuta yabuta self-assigned this Apr 19, 2024
@yabuta yabuta marked this pull request as ready for review April 24, 2024 02:41
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@yabuta
Copy link
Collaborator Author

yabuta commented Apr 24, 2024

I will merge this PR when Mitsudome-san Approves this PR.

@yabuta
Copy link
Collaborator Author

yabuta commented May 9, 2024

I will merge this PR first as this PR may take some time for spell check, etc.

@yabuta yabuta merged commit 48bd70e into tier4/universe May 9, 2024
12 of 15 checks passed
@knzo25 knzo25 deleted the feature/remove_localization_control_vehicle_tool branch May 9, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants