Skip to content

Commit

Permalink
chore(nebula_node_container): confirm ring outlier filter is working …
Browse files Browse the repository at this point in the history
…with the latest versions:

nebula: develop-eval@81afef9ec1cdc1dae9d39e08e916813baab1fd4c
transport_drivers: autowarefoundation/transport_drivers.git@8a93ae022604df8132bd65ab8a599532cf4c0a98
ros2_socketcan: /autowarefoundation/ros2_socketcan.git@2bbdba46ce4177e3076892aa99ede557b4f82446
  • Loading branch information
mojomex committed Sep 17, 2024
1 parent f07001f commit d0b4282
Showing 1 changed file with 18 additions and 18 deletions.
36 changes: 18 additions & 18 deletions aip_x2_gen2_launch/launch/nebula_node_container.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

# from launch.conditions import LaunchConfigurationNotEquals
from launch.conditions import IfCondition
from launch.conditions import LaunchConfigurationEquals
from launch.conditions import LaunchConfigurationEquals, LaunchConfigurationNotEquals
from launch.conditions import UnlessCondition
from launch.substitutions import LaunchConfiguration
from launch_ros.actions import ComposableNodeContainer
Expand Down Expand Up @@ -221,22 +221,22 @@ def str2vector(string):
("~/input/twist", "/sensing/vehicle_velocity_converter/twist_with_covariance"),
("~/input/imu", "/sensing/imu/imu_data"),
("~/input/pointcloud", "mirror_cropped/pointcloud_ex"),
("~/output/pointcloud", "pointcloud"),
("~/output/pointcloud", "rectified/pointcloud_ex"),
],
parameters=[load_composable_node_param("distortion_corrector_node_param_file")],
extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
)

# ring_outlier_filter_component = ComposableNode(
# package="pointcloud_preprocessor",
# plugin="pointcloud_preprocessor::RingOutlierFilterComponent",
# name="ring_outlier_filter",
# remappings=[
# ("input", "rectified/pointcloud_ex"),
# ("output", "pointcloud"),
# ],
# extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
# )
ring_outlier_filter_component = ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::RingOutlierFilterComponent",
name="ring_outlier_filter",
remappings=[
("input", "rectified/pointcloud_ex"),
("output", "pointcloud"),
],
extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
)

dual_return_filter_component = ComposableNode(
package="pointcloud_preprocessor",
Expand Down Expand Up @@ -295,11 +295,11 @@ def str2vector(string):
],
)

# ring_outlier_filter_loader = LoadComposableNodes(
# composable_node_descriptions=[ring_outlier_filter_component],
# target_container=container,
# condition=LaunchConfigurationNotEquals("return_mode", "Dual"),
# )
ring_outlier_filter_loader = LoadComposableNodes(
composable_node_descriptions=[ring_outlier_filter_component],
target_container=container,
condition=LaunchConfigurationNotEquals("return_mode", "Dual"),
)

dual_return_filter_loader = LoadComposableNodes(
composable_node_descriptions=[dual_return_filter_component],
Expand All @@ -315,7 +315,7 @@ def str2vector(string):

return [
container,
# ring_outlier_filter_loader,
ring_outlier_filter_loader,
dual_return_filter_loader,
blockage_diag_loader,
]
Expand Down

0 comments on commit d0b4282

Please sign in to comment.