Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnss_launcher): remove gnss_frame arg #201

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 19, 2024

Description

I removed gnss_frame arg.

gnns_poser refers to msg.header.frame_id instead of parameter gnss_frame.
Please see autowarefoundation/autoware.universe#6116

(The original reason why we can not pass gnss_frame as arg is autowarefoundation/autoware.universe#5140 )

TIER IV INTERNAL ANNOUNCEMENT LINK

Signed-off-by: Kento Yabuuchi <[email protected]>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KYabuuchi KYabuuchi merged commit 43837af into tier4/universe Jan 22, 2024
13 of 14 checks passed
@KYabuuchi KYabuuchi deleted the fix/gnss_poser_frame branch January 22, 2024 09:24
yuki-takagi-66 pushed a commit that referenced this pull request Feb 21, 2024
remove gnss_frame arg

Signed-off-by: Kento Yabuuchi <[email protected]>
0x126 pushed a commit that referenced this pull request Apr 18, 2024
remove gnss_frame arg

Signed-off-by: Kento Yabuuchi <[email protected]>
0x126 added a commit that referenced this pull request Apr 18, 2024
remove gnss_frame arg

Signed-off-by: Kento Yabuuchi <[email protected]>
Co-authored-by: Kento Yabuuchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants