Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_x1): update new sensor configuration #237

Closed
wants to merge 34 commits into from

Conversation

1222-takeshi
Copy link
Contributor

@1222-takeshi 1222-takeshi commented May 2, 2024

This pull request changes the sensor configuration from VLP-16 + Three Livox Horizon to VLP-16 + XT-32.
We have used Livox sensors, but we will not use Livox sensors for future work as they will not be used in any reference designs going forward.
Therefore, supporting Livox sensors in the Nebula driver has become a low priority task.

I have tested using AWSIM.
Autoware Version : pilot-auto.x1/main (2024/5/7)

ros2 launch autoware_launch e2e_simulator.launch.xml vehicle_model:=ymc_golfcart sensor_model:=aip_x1 map_path:=$MAP_PATH/kashiwanoha

image

1222-takeshi and others added 30 commits May 2, 2024 18:32
Signed-off-by: 1222-takeshi <[email protected]>
* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator
fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <[email protected]>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <[email protected]>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <[email protected]>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <[email protected]>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <[email protected]>

* Revert crop_box params

Signed-off-by: Autumn60 <[email protected]>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <[email protected]>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Co-authored-by: 1222-takeshi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <[email protected]>
* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <[email protected]>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <[email protected]>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: 1222-takeshi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@1222-takeshi 1222-takeshi changed the title feat(aip_x1) : update new sensor configuration feat(aip_x1): update new sensor configuration May 7, 2024
Signed-off-by: 1222-takeshi <[email protected]>
@1222-takeshi
Copy link
Contributor Author

This PR is very complex.
Therefore, we will organize it in the following new PR.
#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants