-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remapped topics for the point type migration #248
Conversation
…nt migration Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@h-ohta (maintainerとして)reviewお願いします 🙏 |
@knzo25 common_sensor_launchを過去に作成したのは確かに私でした |
@h-ohta であれば、 |
@drwnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
The main changes are implemented and discussed in autowarefoundation/autoware.universe#6996
Remaps the
velodyne_points
andpandar_points
from nebula to be used directly aspointcloud_raw_ex
in autowareTested using the sample rosbag
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.