Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remapped topics for the point type migration #248

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jul 1, 2024

Description

The main changes are implemented and discussed in autowarefoundation/autoware.universe#6996

Remaps the velodyne_points and pandar_points from nebula to be used directly as pointcloud_raw_ex in autoware
Tested using the sample rosbag

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25 knzo25 requested review from drwnz and mitsudome-r July 1, 2024 07:46
@knzo25 knzo25 changed the title chore: remapped topics for the point type migration chore: remapped topics for the point type migration [DO NOT MERGE] Jul 1, 2024
Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@knzo25 knzo25 requested a review from h-ohta July 2, 2024 08:28
@knzo25
Copy link
Contributor Author

knzo25 commented Jul 2, 2024

@h-ohta (maintainerとして)reviewお願いします 🙏

@h-ohta
Copy link
Contributor

h-ohta commented Jul 2, 2024

@knzo25 common_sensor_launchを過去に作成したのは確かに私でした
ですが、内容については正直判断がつかないため、sensingチームにメンテナを交代してもらいたいです

@knzo25
Copy link
Contributor Author

knzo25 commented Jul 3, 2024

@h-ohta
🙆‍♂️ だと思いますが, @drwnz はどう思いますか?

であれば、
https://github.com/tier4/aip_launcher/blob/tier4/universe/common_sensor_launch/package.xml
にsensing teamのメンバーを追加します

@knzo25
Copy link
Contributor Author

knzo25 commented Jul 3, 2024

@h-ohta
PR出しました( #250
Approveお願いします

@knzo25 knzo25 requested a review from drwnz July 3, 2024 01:24
@knzo25
Copy link
Contributor Author

knzo25 commented Jul 3, 2024

@drwnz
I do not if there was an error or you did not approve the PR (instead making a comment), but please review (approve) again ! 🙏

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@knzo25 knzo25 changed the title chore: remapped topics for the point type migration [DO NOT MERGE] chore: remapped topics for the point type migration Jul 9, 2024
@knzo25 knzo25 merged commit 25cadb3 into tier4/universe Jul 9, 2024
10 of 11 checks passed
@knzo25 knzo25 deleted the feat/point_type_migration branch July 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants