Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aip_x2_launch): read callibration from individual_params #255

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

kotaro-hihara
Copy link

Fixed the calibration_file of nebula to use the default value in nebula_decoders, and now it refers to the calibration file for each sensor from individual_params.

@kotaro-hihara kotaro-hihara requested review from 0x126 and saka1-s July 10, 2024 11:24
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@kotaro-hihara kotaro-hihara merged commit 8ef3f01 into beta/v0.29.0 Jul 10, 2024
8 of 10 checks passed
@kotaro-hihara kotaro-hihara deleted the tmp/v0.29.0_read_calibfile branch July 10, 2024 11:54
Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
* read callibration from individual_params

Signed-off-by: kotaro-hihara <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
* read callibration from individual_params

Signed-off-by: kotaro-hihara <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Autumn60 added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants