Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: x2 gen2/asterx sb3 #286

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

OsamuSekino
Copy link

@OsamuSekino OsamuSekino commented Aug 26, 2024

Description

X2 gen2で使用するGNSS受信機(Septentrio AsteRx SB3 Pro)に対応するためのPRです。Ticket

Tests performed

https://tier4.atlassian.net/browse/RT0-31485?focusedCommentId=183142

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TomohitoAndo TomohitoAndo force-pushed the feat/x2_gen2/asterx_sb3 branch from 757e226 to faa231f Compare August 31, 2024 08:27
@TomohitoAndo
Copy link
Contributor

base branch (beta/x2_gen2/v0.29.0) をrebaseしたため、このbranchもrebaseしてpushし直しました

@TomohitoAndo
Copy link
Contributor

TomohitoAndo commented Aug 31, 2024

(このPRとは関係ないが、このパラメータ定義されているがどこにも使われていなさそうなので、別PRで消す)
https://github.com/tier4/aip_launcher/pull/286/files#diff-509751fb666b94267663c186928e2d23b9d698f308cc211c1ad33aec23f75076R25

Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 67d8c7e into beta/x2_gen2/v0.29.0 Sep 3, 2024
8 of 11 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/x2_gen2/asterx_sb3 branch September 3, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants