-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xacro compilation #361
Open
Owen-Liuyuxuan
wants to merge
14
commits into
tier4/universe
Choose a base branch
from
feat/xacro_compilation
base: tier4/universe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
…itional script for comparing different xacro files for testing; add optional keywords for frame_id Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
…l look Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
…iginal look Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
raw outputs from the xml_diff test script: Analyse files for XX1 sensorsKey Differences1. Include FilesChanges:Added:
2. Sensor Configuration ChangesLidarsParameter Changes:Modified parameters:
Analyse files for XX1 sensor_kitKey Differences1. Include FilesChanges:Added:
2. Sensor Configuration ChangesCamerasParameter Changes:LidarsParameter Changes:ImusParameter Changes:Analyse files for XX1 Gen2 sensorsKey Differences1. Include Files2. Sensor Configuration ChangesLidarsParameter Changes:RadarsParameter Changes:Analyse files for XX1 Gen2 sensor_kitKey Differences1. Include FilesChanges:Added:
2. Sensor Configuration ChangesCamerasParameter Changes:LidarsParameter Changes:ImusParameter Changes: |
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
…_launcher into feat/xacro_compilation
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates (12/20)
Internal Document
Feature 1: Independent
aip_urdf_compiler
This package contains the scripts, templates, tests, and cmake macro. Other packages only need to add
in CMakeLists.txt to get the compilation done.
Feature 2: Optional frame ID annotation in config
Original PR:
#274
Updates (12/13)
After accumulating experience in integration. Here is an updated/robust version that I would like to push forward.
Feature 1: Type Annotation in config
In the Xacro Compilation script, we defined URDF Links into the following types.
Then when sensor configurations are defined as
The compiler will reliably determine what kind of link each transform is.
Feature 2: Force Recompiling on Each Colcon Build
The former PR has the problem of needing to modify the
CMakeLists.txt
to trigger re-compilation. Now we improve theCMakeLists.txt
so that we will create a brand-new urdf every time we rebuild, so that we can make tuning on the fly easily.Description
Proposal of dynamically building xacro files during CMake from sensor calibration configs instead of hard-coding them in the repo.
#275
Methods
Using the jinja2 template mechanism, we can dynamically create as many joints as defined in the calibration Yaml file.
Tricky Problem
To determine the link types, we use the names of the links to infer the types, trying our best to be consistent with the common inputs and also readable. (
determine_link_type
)Test
I have tried successfully launching PSim with the created xacro.