feat(behavior_velocity_traffic_light): ensure stopping if a signal is not received #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce received, is not received again (autowarefoundation#6468) (#1156) feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." * add comments for clarity * fix comments for clarity --------- Signed-off-by: Tomohito Ando <[email protected]>
#1171) feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator * fix comments * fix --------- Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
TomohitoAndo
changed the title
TomohitoAndo
changed the title
TomohitoAndo
requested review from
satoshi-ota,
shmpwk,
tkimura4,
isamu-takagi,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
taikitanaka3,
takayuki5168,
rej55,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
TomohitoAndo
removed request for
mkuri,
rej55,
takayuki5168,
TakaHoribe,
soblin,
kyoichi-sugahara,
kosuke55,
shmpwk,
isamu-takagi,
satoshi-ota and
tkimura4
TomohitoAndo
requested review from
saka1-s
and removed request for
taikitanaka3,
maxime-clem and
zulfaqar-azmi-t4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick following PRs.
The ego vehicle will stop at the traffic light stop line if no signal messages were received.
PR for launch
Tests performed
PSim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.