Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning_debug_tools): fix a bug of perception reproducer #1577

Closed
wants to merge 586 commits into from

Conversation

xtk8532704
Copy link

Description

When the psim-ego stops in front of a red traffic light and the rosbag-ego moves at a distance from the psim-ego, the reproducer stops publishing new messages so the psim-ego freezes forever (because the traffic light keeps red forever).

Related links

Parent Issue:

  • Link

How was this PR tested?

Test with Psim:
(The purple trajectory is rosbag-ego.)
Before:
Screencast from 10-04-2024 06:39:20 PM.webm

After:
Screencast from 10-04-2024 06:38:00 PM.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

SakodaShintaro and others added 30 commits November 22, 2023 13:20
…ation#5511)

* Refactored landmark_parser

Signed-off-by: Shintaro Sakoda <[email protected]>

* Renamed landmark_parser to landmark_manager

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed tag_id

Signed-off-by: Shintaro Sakoda <[email protected]>

* Refactored ar_tag_based_localizer

Signed-off-by: Shintaro Sakoda <[email protected]>

* style(pre-commit): autofix

* Added [[nodiscard]]

Signed-off-by: Shintaro Sakoda <[email protected]>

* Refactored landmark parsing and conversion

Signed-off-by: Shintaro SAKODA <[email protected]>

* style(pre-commit): autofix

* Added namespace

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed include

Signed-off-by: Shintaro Sakoda <[email protected]>

---------

Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…arameters (autowarefoundation#5510)

* Add extra tag for moving obstacle type

Signed-off-by: Daniel Sanchez <[email protected]>

* add static and moving as parameter postfixes

Signed-off-by: Daniel Sanchez <[email protected]>

* set hysteresis-based obstacle moving classification

Signed-off-by: Daniel Sanchez <[email protected]>

* update config params

Signed-off-by: Daniel Sanchez <[email protected]>

* Use speed norm for object classification

Signed-off-by: Daniel Sanchez <[email protected]>

* changed '_' for '.' to make the code more consistent

Signed-off-by: Daniel Sanchez <[email protected]>

* update documentation

Signed-off-by: Daniel Sanchez <[email protected]>

* move the obstacle moving check to generateSlowDownTrajectory

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unnecessary reference

Signed-off-by: Daniel Sanchez <[email protected]>

* add const to certain variables

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
…refoundation#5546)

* refactor(goal_planner): add updateStatus and reduce variables

Signed-off-by: kosuke55 <[email protected]>

refactor

Signed-off-by: kosuke55 <[email protected]>

refactor

Signed-off-by: kosuke55 <[email protected]>

* move to updatedata

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ation#5575)

* fix a bug regarding nearest search

---------

Signed-off-by: Yuki Takagi <[email protected]>
…utowarefoundation#5554)

* refactor(goal_planner): refactoring plan flow and add post process

Signed-off-by: kosuke55 <[email protected]>

do not decel when searching

Signed-off-by: kosuke55 <[email protected]>

rename planPullOver

Signed-off-by: kosuke55 <[email protected]>

* add plan flow

Signed-off-by: kosuke55 <[email protected]>

* add reason of early return

Signed-off-by: kosuke55 <[email protected]>

* typo

Signed-off-by: kosuke55 <[email protected]>

* fix path_candidate_

Signed-off-by: kosuke55 <[email protected]>

* pub path candidate after approval

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
…l wall such as MRM (autowarefoundation#5555)

* feat: add motion_velocity_smoother's virtual wall

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
…on#5439)

* Added pose_instability_detector

Signed-off-by: Shintaro Sakoda <[email protected]>

* Renamed files

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed parameter name

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed to launch

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed to run normally

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed to publish diagnostics

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed a variable name

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed Copyright

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added test

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added maintainer

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added maintainer

Signed-off-by: Shintaro Sakoda <[email protected]>

* Removed log output

Signed-off-by: Shintaro Sakoda <[email protected]>

* Modified test

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed comment

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added a test case

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added set_first_odometry_

Signed-off-by: Shintaro Sakoda <[email protected]>

* Refactored test

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed test

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed topic name

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed position

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added twist message2

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed launch

Signed-off-by: Shintaro Sakoda <[email protected]>

* Updated README.md

Signed-off-by: Shintaro Sakoda <[email protected]>

* style(pre-commit): autofix

* Fixed as pointed out by clang-tidy

Signed-off-by: Shintaro Sakoda <[email protected]>

* Renamed parameters

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed timer

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed README.md

Signed-off-by: Shintaro Sakoda <[email protected]>

* Added debug publishers

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed parameters

Signed-off-by: Shintaro Sakoda <[email protected]>

* style(pre-commit): autofix

* Fixed tests

Signed-off-by: Shintaro Sakoda <[email protected]>

* Changed the type of ekf_to_odom and add const

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed DiagnosticStatus

Signed-off-by: Shintaro Sakoda <[email protected]>

* Changed odometry_data to std::optional

Signed-off-by: Shintaro Sakoda <[email protected]>

* Refactored debug output in pose instability detector

Signed-off-by: Shintaro Sakoda <[email protected]>

* style(pre-commit): autofix

* Remove warning message for negative time
difference in PoseInstabilityDetector

Signed-off-by: Shintaro Sakoda <[email protected]>

* Updated rqt_runtime_monitor.png

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…file path using get_package_share_directory (autowarefoundation#5588)

* use get_package_share_directory

Signed-off-by: Kento Yabuuchi <[email protected]>

* use get_package_share_directory in pose_instability_detector

Signed-off-by: Kento Yabuuchi <[email protected]>

---------

Signed-off-by: Kento Yabuuchi <[email protected]>
…utowarefoundation#5327)

* fix: add 3d validation bind function

Signed-off-by: badai-nguyen <[email protected]>

* fix: check validation point within shape

Signed-off-by: badai-nguyen <[email protected]>

* fix: add 2d validator option param

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

* Revert "chore: refactor"

This reverts commit e3cbf6c.

* chore: update docs and param file

Signed-off-by: badai-nguyen <[email protected]>

* refactor: change to abstract class

Signed-off-by: badai-nguyen <[email protected]>

* chore: add maintainer

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
* fix(goal_planner): fix extending current lanes

Signed-off-by: kosuke55 <[email protected]>

* fix build error

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
…dation#5582)

* feat(lane_departure_checker): better cubstones's search

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
…oundation#5558)

* fix(avoidance): fix wrong reason for unavoidable situation

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): fix misreading variable name

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
…eter to param file (autowarefoundation#5451)

* move radar object clustering parameter to param file

Signed-off-by: yoshiri <[email protected]>

* remove default parameter settings and fix cmakelists

---------

Signed-off-by: yoshiri <[email protected]>
…undation#5557)

* fix(avoidance): consider avoidance prepare time

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): consider avoidance prepare distance

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): use std::optional

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
…refoundation#5572)

* fix(avoidance): prevent sudden steering at yield maneuver

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): output debug info

Signed-off-by: satoshi-ota <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: satoshi-ota <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zulfaqar-azmi-t4 and others added 10 commits September 30, 2024 11:44
* feat(lane_change): cancel hysteresis

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Update documentation

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix the explanation of the hysteresis count

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
feat(perception_reproducer): update new perception reproducer for debugging the version of beta/v0.19.1
…ng off blinker at low velocity (#1571)

Refactor turn signal decider logic and add support for detecting turn signals in turn lanes

Signed-off-by: Kyoichi Sugahara <[email protected]>
Copy link

github-actions bot commented Oct 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

pre-commit-ci bot and others added 4 commits October 4, 2024 09:48
fix(planning_debug_tools): fix a bug of perception reproducer
…-proceed

fix(lane_change): reduce approval chattering
* feat(out_of_lane): ignore lanelets beyond the last path point

Signed-off-by: Maxime CLEMENT <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Oct 8, 2024

@xtk8532704 xtk8532704 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.