-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add radar pipeline #892
Conversation
Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…ion#4992) Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
…usion and fix launch order (autowarefoundation#5166) * fix(tier4_perception_launch): add parameters for light weight radar fusion and fix launch order Signed-off-by: scepter914 <[email protected]> * style(pre-commit): autofix * add far_object_merger_sync_queue_size param for package arg Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: scepter914 <[email protected]>
356a4ec
to
8d14fdf
Compare
Signed-off-by: scepter914 <[email protected]>
<!-- roi based clustering --> | ||
<group> | ||
<include file="$(find-pkg-share image_projection_based_fusion)/launch/roi_pointcloud_fusion.launch.xml" if="$(var use_roi_based_cluster)"> | ||
<arg name="input/camera_info0" value="$(var camera_info0)"/> | ||
<arg name="input/rois0" value="$(var detection_rois0)"/> | ||
<arg name="input/camera_info1" value="$(var camera_info1)"/> | ||
<arg name="input/rois1" value="$(var detection_rois1)"/> | ||
<arg name="input/camera_info2" value="$(var camera_info2)"/> | ||
<arg name="input/rois2" value="$(var detection_rois2)"/> | ||
<arg name="input/camera_info3" value="$(var camera_info3)"/> | ||
<arg name="input/rois3" value="$(var detection_rois3)"/> | ||
<arg name="input/camera_info4" value="$(var camera_info4)"/> | ||
<arg name="input/rois4" value="$(var detection_rois4)"/> | ||
<arg name="input/camera_info5" value="$(var camera_info5)"/> | ||
<arg name="input/rois5" value="$(var detection_rois5)"/> | ||
<arg name="input/camera_info6" value="$(var camera_info6)"/> | ||
<arg name="input/rois6" value="$(var detection_rois6)"/> | ||
<arg name="input/camera_info7" value="$(var camera_info7)"/> | ||
<arg name="input/rois7" value="$(var detection_rois7)"/> | ||
<arg name="input/rois_number" value="$(var image_number)"/> | ||
<arg name="input/image0" value="$(var image_raw0)"/> | ||
<arg name="input/image1" value="$(var image_raw1)"/> | ||
<arg name="input/image2" value="$(var image_raw2)"/> | ||
<arg name="input/image3" value="$(var image_raw3)"/> | ||
<arg name="input/image4" value="$(var image_raw4)"/> | ||
<arg name="input/image5" value="$(var image_raw5)"/> | ||
<arg name="input/image6" value="$(var image_raw6)"/> | ||
<arg name="input/image7" value="$(var image_raw7)"/> | ||
<arg name="input/pointcloud" value="/perception/object_recognition/detection/pointcloud_map_filtered/pointcloud"/> | ||
<arg name="output_clusters" value="roi_cluster/clusters"/> | ||
</include> | ||
</group> | ||
|
||
<!-- simple_cluster_merger --> | ||
<group> | ||
<include file="$(find-pkg-share cluster_merger)/launch/cluster_merger.launch.xml" if="$(var use_roi_based_cluster)"> | ||
<arg name="input/cluster0" value="euclidean_cluster/clusters"/> | ||
<arg name="input/cluster1" value="roi_cluster/clusters"/> | ||
<arg name="output/clusters" value="clusters"/> | ||
</include> | ||
</group> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scepter914 I think this code is duplicated? It is already existed in.
Lines 197 to 228 in eec8629
<!-- roi based clustering --> | |
<group> | |
<include file="$(find-pkg-share image_projection_based_fusion)/launch/roi_pointcloud_fusion.launch.xml" if="$(var use_roi_based_cluster)"> | |
<arg name="input/camera_info0" value="$(var camera_info0)"/> | |
<arg name="input/rois0" value="$(var detection_rois0)"/> | |
<arg name="input/camera_info1" value="$(var camera_info1)"/> | |
<arg name="input/rois1" value="$(var detection_rois1)"/> | |
<arg name="input/camera_info2" value="$(var camera_info2)"/> | |
<arg name="input/rois2" value="$(var detection_rois2)"/> | |
<arg name="input/camera_info3" value="$(var camera_info3)"/> | |
<arg name="input/rois3" value="$(var detection_rois3)"/> | |
<arg name="input/camera_info4" value="$(var camera_info4)"/> | |
<arg name="input/rois4" value="$(var detection_rois4)"/> | |
<arg name="input/camera_info5" value="$(var camera_info5)"/> | |
<arg name="input/rois5" value="$(var detection_rois5)"/> | |
<arg name="input/camera_info6" value="$(var camera_info6)"/> | |
<arg name="input/rois6" value="$(var detection_rois6)"/> | |
<arg name="input/camera_info7" value="$(var camera_info7)"/> | |
<arg name="input/rois7" value="$(var detection_rois7)"/> | |
<arg name="input/rois_number" value="$(var image_number)"/> | |
<arg name="input/image0" value="$(var image_raw0)"/> | |
<arg name="input/image1" value="$(var image_raw1)"/> | |
<arg name="input/image2" value="$(var image_raw2)"/> | |
<arg name="input/image3" value="$(var image_raw3)"/> | |
<arg name="input/image4" value="$(var image_raw4)"/> | |
<arg name="input/image5" value="$(var image_raw5)"/> | |
<arg name="input/image6" value="$(var image_raw6)"/> | |
<arg name="input/image7" value="$(var image_raw7)"/> | |
<arg name="input/pointcloud" value="/perception/object_recognition/detection/pointcloud_map_filtered/pointcloud"/> | |
<arg name="output_clusters" value="roi_cluster/clusters"/> | |
</include> | |
</group> |
I am sorry maybe it was my fault to put it after eculidean clustering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at af3d958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scepter914 thank you. It works now. Could you remove
Lines 197 to 204 in af3d958
<!-- simple_cluster_merger --> | |
<group> | |
<include file="$(find-pkg-share cluster_merger)/launch/cluster_merger.launch.xml" if="$(var use_roi_based_cluster)"> | |
<arg name="input/cluster0" value="euclidean_cluster/clusters"/> | |
<arg name="input/cluster1" value="roi_cluster/clusters"/> | |
<arg name="output/clusters" value="clusters"/> | |
</include> | |
</group> |
this is also duplicated with
Lines 141 to 148 in af3d958
<!-- simple_cluster_merger --> | |
<group> | |
<include file="$(find-pkg-share cluster_merger)/launch/cluster_merger.launch.xml" if="$(var use_roi_based_cluster)"> | |
<arg name="input/cluster0" value="euclidean_cluster/clusters"/> | |
<arg name="input/cluster1" value="roi_cluster/clusters"/> | |
<arg name="output/clusters" value="clusters"/> | |
</include> | |
</group> |
🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at 7f88d81
@scepter914 I was my mistake in Line 191 in eec8629
that make roi_cluster_fusion disconnected with shape_estimation
Could you change back it to: |
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: scepter914 <[email protected]>
Description
Add radar pipeline.
Related links
Tests performed
Tests by rosbag
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.