Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing hard limit on current downloads and documentation wording improvements #203

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Removing hard limit on current downloads and documentation wording improvements #203

merged 3 commits into from
Apr 26, 2024

Conversation

wcornwell
Copy link
Contributor

No description provided.

@wcornwell wcornwell requested a review from ehwenk April 24, 2024 05:38
@fontikar
Copy link
Collaborator

gahhh why is mac failing AGAIN

@wcornwell wcornwell requested a review from fontikar April 24, 2024 06:35
@wcornwell
Copy link
Contributor Author

remotes::install_github("apache/arrow/r@f8ef09a2") works locally, so this was a github change on their mac CI.

fontikar
fontikar reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@fontikar fontikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid mac! Good idea to remove these, could you update the NEWS.md and bump the version number please in the DESCRIPTION

ehwenk
ehwenk approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@ehwenk ehwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I agree that the n_max will create ever more problems, as APC keeps getting longer

@ehwenk
Copy link
Collaborator

ehwenk commented Apr 24, 2024

One of my branches had all tests passing yesterday, and then this evening, oddly switched to the macos test failing - so it isn't specific to this branch

@wcornwell
Copy link
Contributor Author

wcornwell commented Apr 26, 2024 •
edited
Loading

yeah it's a new github CI compiler problem. might get fixed without us doing anything, but it's still broken as of now

@wcornwell wcornwell merged commit e4da0ba into develop Apr 26, 2024
4 of 5 checks passed
@wcornwell wcornwell deleted the small_fixes branch April 26, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fontikar fontikar fontikar left review comments

@ehwenk ehwenk ehwenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wcornwell @fontikar @ehwenk