Skip to content

Commit

Permalink
update project management and review guidelines to use TIP instead of…
Browse files Browse the repository at this point in the history
… INFO
  • Loading branch information
ll7 committed Dec 6, 2024
1 parent 8532d6a commit 094d8ed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion doc/development/project_management.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ Merge the pull request after:

After merging, remember to delete the source branch to keep the repository clean.

>[!INFO] For more information about the review process, see [Review process](./review_guideline.md).
>[!TIP] For more information about the review process, see [Review process](./review_guideline.md).
4 changes: 2 additions & 2 deletions doc/development/review_guideline.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ If a comment of a review was resolved by either, a new commit or a discussion be
If a new commit took place it is encouraged to comment the commit SHA to have a connection between comment and resolving commit
![img.png](../assets/Resolve_conversation.png)

> [!INFO] All conversations should be resolved before merging the pull request.
> [!TIP] All conversations should be resolved before merging the pull request.
## 5. Merging a Pull Request

Expand All @@ -120,7 +120,7 @@ Long story short, the reviewer who approves the PR should merge. Only approve if

Before merging a pull request, the request checks by the CI/CD pipeline should be successful. If the checks fail, the pull request should not be merged.

> [!INFO] An exception can be made for a PR that only addresses the documentation and the `driving` check is not yet completed.
> [!TIP] An exception can be made for a PR that only addresses the documentation and the `driving` check is not yet completed.
### 5.3. Deleting the branch

Expand Down

0 comments on commit 094d8ed

Please sign in to comment.