-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Execute catkin_make on docker compose up #420
Comments
Can you help me understand what is insufficient with the catkin make during the docker build phase? paf/build/docker/agent/Dockerfile Lines 165 to 169 in 4bea66b
|
For python scripts no rebuilding is needed after a file is changed. However for cpp nodes catkin_make needs to compile the code for new changes to apply. This is important if we plan to implement our own rviz/rqt panels, such as in #419. |
With 8694e5e I added a vscode task to the .vscode folder which can be executed when docker container is running. Is it ok to add a new Extension to the recommendations? Should we merge both versions into main, or should we decide on one option? |
|
Description
Currently it is not possible to write cpp code (Nodes or RVIZ-Panels), and be able to use it without either:
1 . rebuilding the entire agent
or 2. opening a shell with the running agent, navigating into catkin_ws and executing catkin_make manually
As I myself doesnt have to much knowledge about docker maybe an expert can give more insight about possible solutions.
This came up in #419.
We should take into consideration that this might not be always wanted for a speedy startup of the leaderboard simulation.
An easy way would be to add it to "entrypoint.sh", but this might not be wanted.
Definition of Done
The text was updated successfully, but these errors were encountered: